Review Request 116645: Simplify a lot the code in SocketLinearReader

Commit Hook null at kde.org
Mon Apr 14 20:06:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116645/#review55775
-----------------------------------------------------------


This review has been submitted with commit 0f734de3e9d976ca7a4ea6f4a7889b9e602bddb9 by Àlex Fiestas to branch master.

- Commit Hook


On March 7, 2014, 12:07 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116645/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 12:07 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Use QIODevice canReadLine and readLine instead of our own implementation.
> 
> 
> Diffs
> -----
> 
>   kded/backends/lan/socketlinereader.cpp 4cd8ef0 
> 
> Diff: https://git.reviewboard.kde.org/r/116645/diff/
> 
> 
> Testing
> -------
> 
> Unittest pass, ping and mpris seem to be responsive and work with no problem.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140414/d74ee457/attachment.html>


More information about the KDEConnect mailing list