Review Request 120878: Remove unused header

David Edmundson david at davidedmundson.co.uk
Sat Nov 29 19:39:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/#review71093
-----------------------------------------------------------

Ship it!


I just tested the Linux build still compiles fine. Ship it

- David Edmundson


On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120878/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 2:27 a.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Plasma.
> 
> 
> Repository: krunner
> 
> 
> Description
> -------
> 
> Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript.
> 
> 
> Diffs
> -----
> 
>   src/abstractrunner.cpp 4da0394 
> 
> Diff: https://git.reviewboard.kde.org/r/120878/diff/
> 
> 
> Testing
> -------
> 
> Tested building using MSVC 64bit
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20141129/08f0b57f/attachment.html>


More information about the Kde-windows mailing list