Review Request 117649: gcrypt: Fix VERSION variable in generated gcrypt.h

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117649/#review56069
-----------------------------------------------------------

Ship it!


I guess the reason for the problem originally is that the cmake config.h file is derived from the autotools one (only with some scripted changes sed/#define/#cmakedefine/ etc.). So the way to provide the correct version number is this ugly way in cmake. If this change improves the version handling, then it obviously should go in right away though.
I have to say though that for gcrypt we will have to maintain the cmake stuff ourselves anyway, so no need to be shy here: just commit it.

- Patrick Spendrin


On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117649/
> -----------------------------------------------------------
> 
> (Updated April 19, 2014, 7:24 p.m.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> It was generating #define GCRYPT_VERSION ""1.5.3"" (with duplicated quotes), now it's the correct "1.5.3".
> 
> Note that this patch might not apply cleanly on its own as I made it on top of review #117646; but I can rebase it if requested.
> 
> 
> Diffs
> -----
> 
>   portage/win32libs/gcrypt/libgcrypt-1.5.3-cmake.diff 5f0ad04 
> 
> Diff: https://git.reviewboard.kde.org/r/117649/diff/
> 
> 
> Testing
> -------
> 
> Builds, MSVC2010. Visually inspected generated gcrypt.h.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140419/9009e6cd/attachment.html>