Review Request 117649: gcrypt: Fix VERSION variable in generated gcrypt.h
Commit Hook
null at kde.org
Sat Apr 19 23:48:29 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117649/#review56071
-----------------------------------------------------------
This review has been submitted with commit 80e283fc52994cc5ed963812a9f9c5b8cc39c7cb by Nicolás Alvarez to branch qt5.
- Commit Hook
On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117649/
> -----------------------------------------------------------
>
> (Updated April 19, 2014, 7:24 p.m.)
>
>
> Review request for kdewin.
>
>
> Repository: emerge
>
>
> Description
> -------
>
> It was generating #define GCRYPT_VERSION ""1.5.3"" (with duplicated quotes), now it's the correct "1.5.3".
>
> Note that this patch might not apply cleanly on its own as I made it on top of review #117646; but I can rebase it if requested.
>
>
> Diffs
> -----
>
> portage/win32libs/gcrypt/libgcrypt-1.5.3-cmake.diff 5f0ad04
>
> Diff: https://git.reviewboard.kde.org/r/117649/diff/
>
>
> Testing
> -------
>
> Builds, MSVC2010. Visually inspected generated gcrypt.h.
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140419/428cebf9/attachment.html>
More information about the Kde-windows
mailing list