<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117649/">https://git.reviewboard.kde.org/r/117649/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess the reason for the problem originally is that the cmake config.h file is derived from the autotools one (only with some scripted changes sed/#define/#cmakedefine/ etc.). So the way to provide the correct version number is this ugly way in cmake. If this change improves the version handling, then it obviously should go in right away though.
I have to say though that for gcrypt we will have to maintain the cmake stuff ourselves anyway, so no need to be shy here: just commit it.</pre>
<br />
<p>- Patrick Spendrin</p>
<br />
<p>On April 19th, 2014, 7:24 p.m. UTC, Nicolás Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated April 19, 2014, 7:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was generating #define GCRYPT_VERSION ""1.5.3"" (with duplicated quotes), now it's the correct "1.5.3".
Note that this patch might not apply cleanly on its own as I made it on top of review #117646; but I can rebase it if requested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, MSVC2010. Visually inspected generated gcrypt.h.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/win32libs/gcrypt/libgcrypt-1.5.3-cmake.diff <span style="color: grey">(5f0ad04)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>