Review Request: libkgapi - Fix MSVC build.

[Andrius da Costa Ribas]

> On Oct. 8, 2012, 7:13 p.m., Dan Vratil wrote:
> > libkgapi/objects/calendar.h, line 39
> > <http://git.reviewboard.kde.org/r/106760/diff/2/?file=88750#file88750line39>
> >
> >     Should be 
> >     
> >     #include <libkgapi/objects/reminder.h>
> >     
> >     and move it below the other libkgapi includes.

in this point I'm also removing the include of libkgapi_export.h, since it's already being included by object.h


- Andrius da Costa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106760/#review20053
-----------------------------------------------------------


On Oct. 11, 2012, 3 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106760/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 3 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, kdewin and Dan Vratil.
> 
> 
> Description
> -------
> 
> General fixes to allow MSVC build + cleanups.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a1da482 
>   libkgapi/CMakeLists.txt 60ffa42 
>   libkgapi/account.h fd23555 
>   libkgapi/account.cpp f05803d 
>   libkgapi/account_p.h PRE-CREATION 
>   libkgapi/object.h 0df55c9 
>   libkgapi/object.cpp 01381a0 
>   libkgapi/object_p.h PRE-CREATION 
>   libkgapi/objects/accountinfo.h 179af23 
>   libkgapi/objects/accountinfo.cpp 2b20cfa 
>   libkgapi/objects/accountinfo_p.h b076af7 
>   libkgapi/objects/calendar.h 00b150e 
>   libkgapi/objects/calendar.cpp c45a30f 
>   libkgapi/objects/calendar_p.h 58512d4 
>   libkgapi/objects/contact.h 6fcbb3c 
>   libkgapi/objects/contact.cpp c758083 
>   libkgapi/objects/contact_p.h 4da6b86 
>   libkgapi/objects/contactsgroup.h c4c125c 
>   libkgapi/objects/contactsgroup.cpp 71edcec 
>   libkgapi/objects/contactsgroup_p.h 32b318d 
>   libkgapi/objects/location.h 2a320f1 
>   libkgapi/objects/location.cpp 01b3b12 
>   libkgapi/objects/location_p.h 52f3ab7 
>   libkgapi/objects/reminder.h PRE-CREATION 
>   libkgapi/objects/reminder.cpp PRE-CREATION 
>   libkgapi/objects/reminder_p.h PRE-CREATION 
>   libkgapi/objects/tasklist.h df596e9 
>   libkgapi/objects/tasklist.cpp d925a0f 
>   libkgapi/objects/tasklist_p.h PRE-CREATION 
>   libkgapi/ui/accountscombo.cpp 0b1fd46 
> 
> Diff: http://git.reviewboard.kde.org/r/106760/diff/
> 
> 
> Testing
> -------
> 
> Build completed on msvc 2010
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20121011/ec24b409/attachment.html>