<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106760/">http://git.reviewboard.kde.org/r/106760/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 8th, 2012, 7:13 p.m., <b>Dan Vratil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106760/diff/2/?file=88750#file88750line39" style="color: black; font-weight: bold; text-decoration: underline;">libkgapi/objects/calendar.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">using namespace KCal;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "reminder.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be
#include <libkgapi/objects/reminder.h>
and move it below the other libkgapi includes.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in this point I'm also removing the include of libkgapi_export.h, since it's already being included by object.h</pre>
<br />
<p>- Andrius da Costa</p>
<br />
<p>On October 11th, 2012, 3 a.m., Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM-Libraries, kdewin and Dan Vratil.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2012, 3 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">General fixes to allow MSVC build + cleanups.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build completed on msvc 2010</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a1da482)</span></li>
<li>libkgapi/CMakeLists.txt <span style="color: grey">(60ffa42)</span></li>
<li>libkgapi/account.h <span style="color: grey">(fd23555)</span></li>
<li>libkgapi/account.cpp <span style="color: grey">(f05803d)</span></li>
<li>libkgapi/account_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/object.h <span style="color: grey">(0df55c9)</span></li>
<li>libkgapi/object.cpp <span style="color: grey">(01381a0)</span></li>
<li>libkgapi/object_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/objects/accountinfo.h <span style="color: grey">(179af23)</span></li>
<li>libkgapi/objects/accountinfo.cpp <span style="color: grey">(2b20cfa)</span></li>
<li>libkgapi/objects/accountinfo_p.h <span style="color: grey">(b076af7)</span></li>
<li>libkgapi/objects/calendar.h <span style="color: grey">(00b150e)</span></li>
<li>libkgapi/objects/calendar.cpp <span style="color: grey">(c45a30f)</span></li>
<li>libkgapi/objects/calendar_p.h <span style="color: grey">(58512d4)</span></li>
<li>libkgapi/objects/contact.h <span style="color: grey">(6fcbb3c)</span></li>
<li>libkgapi/objects/contact.cpp <span style="color: grey">(c758083)</span></li>
<li>libkgapi/objects/contact_p.h <span style="color: grey">(4da6b86)</span></li>
<li>libkgapi/objects/contactsgroup.h <span style="color: grey">(c4c125c)</span></li>
<li>libkgapi/objects/contactsgroup.cpp <span style="color: grey">(71edcec)</span></li>
<li>libkgapi/objects/contactsgroup_p.h <span style="color: grey">(32b318d)</span></li>
<li>libkgapi/objects/location.h <span style="color: grey">(2a320f1)</span></li>
<li>libkgapi/objects/location.cpp <span style="color: grey">(01b3b12)</span></li>
<li>libkgapi/objects/location_p.h <span style="color: grey">(52f3ab7)</span></li>
<li>libkgapi/objects/reminder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/objects/reminder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/objects/reminder_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/objects/tasklist.h <span style="color: grey">(df596e9)</span></li>
<li>libkgapi/objects/tasklist.cpp <span style="color: grey">(d925a0f)</span></li>
<li>libkgapi/objects/tasklist_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkgapi/ui/accountscombo.cpp <span style="color: grey">(0b1fd46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106760/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>