Review Request: libkgapi - Fix MSVC build.

[Dan Vratil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106760/#review20053
-----------------------------------------------------------


Looks good, just a few small issues :)


libkgapi/account.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15917>

    This is not going to work. Use
    
    Account::Account(const Account &other):
      d(new AccountPrivate(*other.d))
    { }
    



libkgapi/object.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15918>

    Same as Account copy constructor, remember to add a copy constructor to ObjectPrivate.



libkgapi/objects/accountinfo.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15920>

    Same as Account copy constructor.



libkgapi/objects/accountinfo_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15921>

    This is not your fault, the naming is already inconsistent, but could you please change the naming of the private classes from *Data to *Private? So AccountInfoPrivate, CalendarPrivate etc. 



libkgapi/objects/calendar.h
<http://git.reviewboard.kde.org/r/106760/#comment15935>

    Should be 
    
    #include <libkgapi/objects/reminder.h>
    
    and move it below the other libkgapi includes.



libkgapi/objects/calendar.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15922>

    Same as Account copy constructor



libkgapi/objects/calendar_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15923>

    *Data -> *Private



libkgapi/objects/contact.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15924>

    Move this to the initialization please :)



libkgapi/objects/contact.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15925>

    Same as Account copy constructor



libkgapi/objects/contact_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15926>

    *Data -> *Private



libkgapi/objects/contactsgroup.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15927>

    Same as Account copy constructor.



libkgapi/objects/location.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15928>

    Same as Account copy constructor.



libkgapi/objects/location_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15929>

    *Data -> *Private



libkgapi/objects/reminder.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15931>

    Same as Account copy constructor.



libkgapi/objects/reminder_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15932>

    *Data -> *Private



libkgapi/objects/tasklist.h
<http://git.reviewboard.kde.org/r/106760/#comment15884>

    



libkgapi/objects/tasklist.cpp
<http://git.reviewboard.kde.org/r/106760/#comment15933>

    Same as with Account's copy constructor



libkgapi/objects/tasklist_p.h
<http://git.reviewboard.kde.org/r/106760/#comment15934>

    *Data -> *Private


- Dan Vratil


On Oct. 8, 2012, 1:01 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106760/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 1:01 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, kdewin and Dan Vratil.
> 
> 
> Description
> -------
> 
> General fixes to allow MSVC build + cleanups.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a1da482 
>   libkgapi/CMakeLists.txt 60ffa42 
>   libkgapi/account.h fd23555 
>   libkgapi/account.cpp f05803d 
>   libkgapi/account_p.h PRE-CREATION 
>   libkgapi/object.h 0df55c9 
>   libkgapi/object.cpp 01381a0 
>   libkgapi/object_p.h PRE-CREATION 
>   libkgapi/objects/accountinfo.h 179af23 
>   libkgapi/objects/accountinfo.cpp 2b20cfa 
>   libkgapi/objects/accountinfo_p.h b076af7 
>   libkgapi/objects/calendar.h 00b150e 
>   libkgapi/objects/calendar.cpp c45a30f 
>   libkgapi/objects/calendar_p.h 58512d4 
>   libkgapi/objects/contact.h 6fcbb3c 
>   libkgapi/objects/contact.cpp c758083 
>   libkgapi/objects/contact_p.h 4da6b86 
>   libkgapi/objects/contactsgroup.h c4c125c 
>   libkgapi/objects/contactsgroup.cpp 71edcec 
>   libkgapi/objects/contactsgroup_p.h 32b318d 
>   libkgapi/objects/location.h 2a320f1 
>   libkgapi/objects/location.cpp 01b3b12 
>   libkgapi/objects/location_p.h 52f3ab7 
>   libkgapi/objects/reminder.h PRE-CREATION 
>   libkgapi/objects/reminder.cpp PRE-CREATION 
>   libkgapi/objects/reminder_p.h PRE-CREATION 
>   libkgapi/objects/tasklist.h df596e9 
>   libkgapi/objects/tasklist.cpp d925a0f 
>   libkgapi/objects/tasklist_p.h PRE-CREATION 
>   libkgapi/ui/accountscombo.cpp 0b1fd46 
> 
> Diff: http://git.reviewboard.kde.org/r/106760/diff/
> 
> 
> Testing
> -------
> 
> Build completed on msvc 2010
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20121008/3d273322/attachment-0001.html>