emerge/bin/Source/GitSource: git createPatch is wrong for python sources

Andre Heinecke aheinecke at intevation.de
Tue Mar 15 17:06:53 CET 2011


Am Dienstag, 15. März 2011 12:34:05 schrieb Wolfgang Rohdewald:
> because leading space has a meaning, but those differences
> will not be in the patch file.
Actually i did not think about python there at all. In the case of create 
patch the --ignore-all-space should be removed in my opinion. I've added it 
in the hope so that fewer patches with accidental whitespace changes would be 
commited to emerge.

> Author: aheinecke <aheinecke at 283d02a7-25f6-0310-bc7c-
> ecb5cbfe19da>
> Date:   Thu Sep 16 13:50:00 2010 +0000
>     Ignore whitespaces when creating and applying git patches.
>         This has often be the cause for bad patches in emerge
> which
>         were not applied.

The --whitespace=fix i would really like to keep there, from my understanding 
this should only correct whitespace errors ( line endings, whitespace in 
empty lines ) which would otherwise be reported as errors. 


Andre Heinecke |  ++49-541-335083-262 |  http://www.intevation.de/
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 18998
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner

More information about the Kde-windows mailing list