Review Request: GitSource: define a helper for calling git, suppress progress info for logfile
Ralf Habacker
ralf at habacker.de
Sun Mar 27 19:09:03 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6613/#review10035
-----------------------------------------------------------
Ship it!
- Ralf
On March 27, 2011, 4:36 p.m., Wolfgang Rohdewald wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6613/
> -----------------------------------------------------------
>
> (Updated March 27, 2011, 4:36 p.m.)
>
>
> Review request for kde-windows.
>
>
> Summary
> -------
>
> - no hanging git when cloning qt
> - calling git directly (no MSysShell needed anymore with current git)
> - much less clutter in the logfile without MSysShell
>
> however this does more calls to checkoutDir(). I have one more patch which
> caches this within GitSource but it depends on this patch
>
>
> Diffs
> -----
>
> /trunk/kdesupport/emerge/bin/Source/GitSource.py 1225001
>
> Diff: http://svn.reviewboard.kde.org/r/6613/diff
>
>
> Testing
> -------
>
> building qt and kdelibs
>
>
> Thanks,
>
> Wolfgang
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110327/68d23730/attachment.htm
More information about the Kde-windows
mailing list