Review Request: get rid of className argument in EmergeBase and descendants

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6532/
-----------------------------------------------------------

(Updated Feb. 21, 2011, 9:23 a.m.)


Review request for kde-windows.


Changes
-------

I wonder why pylint did not find this. Fixed now.


Summary
-------

instead do this dynamically - for the class and all of its ancestors check
if internal dependencies are defined. If EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES
is set, depend on them.


Diffs (updated)
-----

  /trunk/kdesupport/emerge/bin/BuildSystem/AutoToolsBuildSystem.py 1221559 
  /trunk/kdesupport/emerge/bin/BuildSystem/BinaryBuildSystem.py 1221559 
  /trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py 1221559 
  /trunk/kdesupport/emerge/bin/BuildSystem/CMakeBuildSystem.py 1221559 
  /trunk/kdesupport/emerge/bin/BuildSystem/MakeFileBuildSystem.py 1221559 
  /trunk/kdesupport/emerge/bin/BuildSystem/QMakeBuildSystem.py 1221559 
  /trunk/kdesupport/emerge/bin/EmergeBase.py 1221559 
  /trunk/kdesupport/emerge/bin/Packager/PackagerBase.py 1221559 
  /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1221559 
  /trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py 1221559 

Diff: http://svn.reviewboard.kde.org/r/6532/diff


Testing
-------

if that long shell variable is set, the dependencies are added as before


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110221/62da17f7/attachment.htm