Review Request: get rid of className argument in EmergeBase and descendants

[Ralf Habacker]

> On Feb. 21, 2011, 7:06 a.m., Ralf Habacker wrote:
> > The basic idea looks good, but the patch is incomplete. You removed the className parameter but the derived classes in Source, Buildsystem and Packager still provides this parameter. 
> >
> 
> Wolfgang Rohdewald wrote:
>     I am not sure what went wrong - I did change the derived classes, and if I download this patch and apply it, I cannot find className there. Where do you still see it?

You changed in BuildSystemBase.py 

 def __init__(self, typeName, className=None):

to 

 def __init__(self, typeName):


but in CMakeBuildSystem.py and other classes derived from BuildSystemBase there is still the third parameter 

        BuildSystemBase.__init__(self, "cmake", "CMakeBuildSystem")

Similar in source subdirectory


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6532/#review9894
-----------------------------------------------------------


On Feb. 20, 2011, 6:27 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6532/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 6:27 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> instead do this dynamically - for the class and all of its ancestors check
> if internal dependencies are defined. If EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES
> is set, depend on them.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py 1221710 
>   /trunk/kdesupport/emerge/bin/EmergeBase.py 1221711 
>   /trunk/kdesupport/emerge/bin/Packager/PackagerBase.py 1221710 
>   /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1221711 
>   /trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py 1221711 
> 
> Diff: http://svn.reviewboard.kde.org/r/6532/diff
> 
> 
> Testing
> -------
> 
> if that long shell variable is set, the dependencies are added as before
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110221/1743ac8a/attachment.htm