<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6532/">http://svn.reviewboard.kde.org/r/6532/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2011, 7:06 a.m., <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The basic idea looks good, but the patch is incomplete. You removed the className parameter but the derived classes in Source, Buildsystem and Packager still provides this parameter.
</pre>
</blockquote>
<p>On February 21st, 2011, 8:17 a.m., <b>Wolfgang Rohdewald</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure what went wrong - I did change the derived classes, and if I download this patch and apply it, I cannot find className there. Where do you still see it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You changed in BuildSystemBase.py
def __init__(self, typeName, className=None):
to
def __init__(self, typeName):
but in CMakeBuildSystem.py and other classes derived from BuildSystemBase there is still the third parameter
BuildSystemBase.__init__(self, "cmake", "CMakeBuildSystem")
Similar in source subdirectory
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 20th, 2011, 6:27 p.m., Wolfgang Rohdewald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2011, 6:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead do this dynamically - for the class and all of its ancestors check
if internal dependencies are defined. If EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES
is set, depend on them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if that long shell variable is set, the dependencies are added as before</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py <span style="color: grey">(1221710)</span></li>
<li>/trunk/kdesupport/emerge/bin/EmergeBase.py <span style="color: grey">(1221711)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/PackagerBase.py <span style="color: grey">(1221710)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SourceBase.py <span style="color: grey">(1221711)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py <span style="color: grey">(1221711)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6532/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>