[review-request] K3B - Windows/MinGW

[Andrius da Costa Ribas]

Hi,

Please find attached the proposed patch for K3B compiling on MinGW.

My comments:
...
+else(NOT WIN32)
+ target_link_libraries(k3b uuid ole32)
...
without linking to these libraries I got several linking errors such as:
C:/Users/Andrius/Desktop/kdetest/jr/k3b/libk3b/tools/qprocess/private/qfsfileengine_win.cpp:1457:
undefined reference to `CoCreateInstance at 20'

+set_target_properties(k3b PROPERTIES OUTPUT_NAME k3blib)
libk3b.dll.a was being generated twice, causing errors:
Linking CXX shared library ..\bin\libk3b.dll
Creating library file: ..\bin\libk3b.dll.a
[ 46%] Built target k3b
[ 46%] Built target k3b_bin_automoc
Linking CXX executable ..\bin\k3b.exe
Creating library file: ..\bin\libk3b.dll.a
C:\MinGW\Bin/ld.exe: final link failed: File truncated
collect2: ld returned 1 exit status
mingw32-make[2]: *** [bin/k3b.exe] Error 1
mingw32-make[1]: *** [src/CMakeFiles/k3b_bin.dir/all] Error 2
mingw32-make: *** [all] Error 2


-inline void *dlsym(void *a, char *b)
+inline void *dlsym(void *a, const char *b)


conversions between char* and const char* were failing on MinGW, also the
linux manpages defines the second parameter of dlsym as const char*


Could you please confirm if this does not hurt MSVC or linux?

obs.: K3B halts on initialization using 4.3.4 kdelibs, but works normally
using latest svn of kdelibs.

Thanks,
Andrius da Costa Ribas.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20091223/80808280/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: k3b.patch
Type: application/octet-stream
Size: 1119 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-windows/attachments/20091223/80808280/attachment.dll