Hi,<div><br></div><div>Please find attached the proposed patch for K3B compiling on MinGW.</div><div><br></div><div>My comments:</div><div>...</div><div><div>+else(NOT WIN32)</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>target_link_libraries(k3b uuid ole32)</div>
<div>...</div><div>without linking to these libraries I got several linking errors such as:</div><div><div>C:/Users/Andrius/Desktop/kdetest/jr/k3b/libk3b/tools/qprocess/private/qfsfileengine_win.cpp:1457: undefined reference to `CoCreateInstance@20'</div>
<div><br></div><div>+set_target_properties(k3b PROPERTIES OUTPUT_NAME k3blib)</div><div>libk3b.dll.a was being generated twice, causing errors:</div><div><div>Linking CXX shared library ..\bin\libk3b.dll</div><div>Creating library file: ..\bin\libk3b.dll.a</div>
<div>[ 46%] Built target k3b</div><div>[ 46%] Built target k3b_bin_automoc</div><div>Linking CXX executable ..\bin\k3b.exe</div><div>Creating library file: ..\bin\libk3b.dll.a</div><div>C:\MinGW\Bin/ld.exe: final link failed: File truncated</div>
<div>collect2: ld returned 1 exit status</div><div>mingw32-make[2]: *** [bin/k3b.exe] Error 1</div><div>mingw32-make[1]: *** [src/CMakeFiles/k3b_bin.dir/all] Error 2</div><div>mingw32-make: *** [all] Error 2</div><div><br>
</div><div><br></div><div><div>-inline void *dlsym(void *a, char *b)</div><div>+inline void *dlsym(void *a, const char *b)</div><div><br></div><div><br></div><div>conversions between char* and const char* were failing on MinGW, also the linux manpages defines the second parameter of dlsym as const char*</div>
<div><br></div><div><br></div><div>Could you please confirm if this does not hurt MSVC or linux?</div><div><br></div><div>obs.: K3B halts on initialization using 4.3.4 kdelibs, but works normally using latest svn of kdelibs.</div>
<div><br></div><div>Thanks,</div><div>Andrius da Costa Ribas.</div></div></div></div></div>