D8719: Fix building the bittorrent plugin

Wolfgang Bauer noreply at phabricator.kde.org
Wed Nov 8 12:20:35 UTC 2017


wbauer created this revision.
wbauer added reviewers: KDE Applications, kde-utils-devel.

REVISION SUMMARY
  - use the correct cmake variable to test whether it should be built (it wasn't built at all even if libktorrent was available)
  - port KUrl to QUrl, necessary by changes to the rest of the code
  - add missing link libraries
  - add missing includes, correct wrong ones
  - some other changes required to make it compile

TEST PLAN
  - the plugin is actually built now (if libktorrent is found) and it compiles fine
  - it shows up in kget's settings
  - added a torrent, the download started (with the multiseg plugin disabled, which still has problems)

REPOSITORY
  R433 KGet

REVISION DETAIL
  https://phabricator.kde.org/D8719

AFFECTED FILES
  transfer-plugins/CMakeLists.txt
  transfer-plugins/bittorrent/CMakeLists.txt
  transfer-plugins/bittorrent/advanceddetails/btadvanceddetailswidget.cpp
  transfer-plugins/bittorrent/advanceddetails/chunkdownloadview.cpp
  transfer-plugins/bittorrent/advanceddetails/fileview.cpp
  transfer-plugins/bittorrent/advanceddetails/peerviewmodel.cpp
  transfer-plugins/bittorrent/advanceddetails/peerviewmodel.h
  transfer-plugins/bittorrent/advanceddetails/torrentfiletreemodel.cpp
  transfer-plugins/bittorrent/advanceddetails/trackermodel.cpp
  transfer-plugins/bittorrent/advanceddetails/trackermodel.h
  transfer-plugins/bittorrent/advanceddetails/trackerview.cpp
  transfer-plugins/bittorrent/advanceddetails/trackerview.h
  transfer-plugins/bittorrent/advanceddetails/webseedsmodel.cpp
  transfer-plugins/bittorrent/advanceddetails/webseedstab.cpp
  transfer-plugins/bittorrent/advanceddetails/webseedstab.h
  transfer-plugins/bittorrent/bittorrentsettings.kcfgc
  transfer-plugins/bittorrent/btdatasource.cpp
  transfer-plugins/bittorrent/btdatasource.h
  transfer-plugins/bittorrent/btdetailswidget.cpp
  transfer-plugins/bittorrent/btsettingswidget.cpp
  transfer-plugins/bittorrent/bttransfer.cpp
  transfer-plugins/bittorrent/bttransfer.h
  transfer-plugins/bittorrent/bttransferfactory.cpp
  transfer-plugins/bittorrent/bttransferfactory.h
  transfer-plugins/bittorrent/bttransferhandler.cpp
  transfer-plugins/bittorrent/scandlg.cpp

To: wbauer, #kde_applications, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20171108/f4259f5c/attachment.html>


More information about the Kde-utils-devel mailing list