<table><tr><td style="">wbauer created this revision.<br />wbauer added reviewers: KDE Applications, kde-utils-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8719" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">use the correct cmake variable to test whether it should be built (it wasn't built at all even if libktorrent was available)</li>
<li class="remarkup-list-item">port KUrl to QUrl, necessary by changes to the rest of the code</li>
<li class="remarkup-list-item">add missing link libraries</li>
<li class="remarkup-list-item">add missing includes, correct wrong ones</li>
<li class="remarkup-list-item">some other changes required to make it compile</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">the plugin is actually built now (if libktorrent is found) and it compiles fine</li>
<li class="remarkup-list-item">it shows up in kget's settings</li>
<li class="remarkup-list-item">added a torrent, the download started (with the multiseg plugin disabled, which still has problems)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R433 KGet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8719" rel="noreferrer">https://phabricator.kde.org/D8719</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>transfer-plugins/CMakeLists.txt<br />
transfer-plugins/bittorrent/CMakeLists.txt<br />
transfer-plugins/bittorrent/advanceddetails/btadvanceddetailswidget.cpp<br />
transfer-plugins/bittorrent/advanceddetails/chunkdownloadview.cpp<br />
transfer-plugins/bittorrent/advanceddetails/fileview.cpp<br />
transfer-plugins/bittorrent/advanceddetails/peerviewmodel.cpp<br />
transfer-plugins/bittorrent/advanceddetails/peerviewmodel.h<br />
transfer-plugins/bittorrent/advanceddetails/torrentfiletreemodel.cpp<br />
transfer-plugins/bittorrent/advanceddetails/trackermodel.cpp<br />
transfer-plugins/bittorrent/advanceddetails/trackermodel.h<br />
transfer-plugins/bittorrent/advanceddetails/trackerview.cpp<br />
transfer-plugins/bittorrent/advanceddetails/trackerview.h<br />
transfer-plugins/bittorrent/advanceddetails/webseedsmodel.cpp<br />
transfer-plugins/bittorrent/advanceddetails/webseedstab.cpp<br />
transfer-plugins/bittorrent/advanceddetails/webseedstab.h<br />
transfer-plugins/bittorrent/bittorrentsettings.kcfgc<br />
transfer-plugins/bittorrent/btdatasource.cpp<br />
transfer-plugins/bittorrent/btdatasource.h<br />
transfer-plugins/bittorrent/btdetailswidget.cpp<br />
transfer-plugins/bittorrent/btsettingswidget.cpp<br />
transfer-plugins/bittorrent/bttransfer.cpp<br />
transfer-plugins/bittorrent/bttransfer.h<br />
transfer-plugins/bittorrent/bttransferfactory.cpp<br />
transfer-plugins/bittorrent/bttransferfactory.h<br />
transfer-plugins/bittorrent/bttransferhandler.cpp<br />
transfer-plugins/bittorrent/scandlg.cpp</div></div></div><br /><div><strong>To: </strong>wbauer, KDE Applications, kde-utils-devel<br /></div>