D6001: Ark: kerfuffle plugin Mac adaptation

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Is `otool` even available on linux? If a mac user also has `ldd` that wouldn't be a problem, as long as we put the `findExecutable(ldd)` in the else branch (so if `otool` is found, we use it).
  
  Anyway, if you *really* want to make this a compile-time check, then I'd prefer to use cmake magic, something like:
  
    if (APPLE)
       target_compile_definitions(kerfuffle -DDEPENDENCY_TOOL=otool)
       target_compile_definitions(kerfuffle -DDEPENDENCY_TOOL_ARGS=-L)
    else()
      # define as ldd...
    endif()
  
  and then in the code just:
  
    dependencyTool.setProgram(QStringLiteral(DEPENDENCY_TOOL));
  
  without ifdefs.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D6001

To: rjvbb, #ark, elvisangelaccio
Cc: elvisangelaccio, kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170529/8f8662d7/attachment.html>