Review Request 129352: Port to QStandardPaths

[Heiko Becker]

> On Nov. 6, 2016, 9:28 nachm., Christoph Feck wrote:
> > privacyfunctions.cpp, line 142
> > <https://git.reviewboard.kde.org/r/129352/diff/1/?file=484270#file484270line142>
> >
> >     Could you please check if this is actually found? As far as I know, the KStandardDirs::findExe also searched the KDE libexec/ path, while Qt most certainly will not.
> >     
> >     On my system, the actual path is /usr/lib64/libexec/kf5/kio_http_cache_cleaner
> >     
> >     Btw, does this compile without include QStandardPaths?

Good point. Because the standard location for kio_http_cache_cleaner is KDE_INSTALL_LIBEXECDIR_KF5 i took the porting notes advice ("except when the executable comes from libexec, in which case the path should just be hardcoded").

QStandardPaths is already included (from an previous porting effort).


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129352/#review100664
-----------------------------------------------------------


On Nov. 9, 2016, 10:13 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129352/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 10:13 nachm.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: sweeper
> 
> 
> Description
> -------
> 
> Port to QStandardPaths
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 05e82ef 
>   config-sweeper.h.cmake PRE-CREATION 
>   privacyfunctions.cpp 902a697 
> 
> Diff: https://git.reviewboard.kde.org/r/129352/diff/
> 
> 
> Testing
> -------
> 
> Builds. Checked that kio_http_cache_cleaner --clear-all gets executed and that KBookmarkManager gets passed the actual path to konqueror's bookmarks.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161109/bfcb02a9/attachment.html>