Review Request 129352: Port to QStandardPaths

Elvis Angelaccio elvis.angelaccio at kde.org
Sun Nov 6 21:53:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129352/#review100669
-----------------------------------------------------------




privacyfunctions.cpp (line 174)
<https://git.reviewboard.kde.org/r/129352/#comment67598>

    This is wrong, according to https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs
    
    You should use QStandardPaths::writableLocation() and also create the parent directory if necessary


- Elvis Angelaccio


On Nov. 6, 2016, 7:25 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129352/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 7:25 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: sweeper
> 
> 
> Description
> -------
> 
> Port to QStandardPaths
> 
> 
> Diffs
> -----
> 
>   privacyfunctions.cpp 902a697 
> 
> Diff: https://git.reviewboard.kde.org/r/129352/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161106/c9b8622a/attachment-0001.html>


More information about the Kde-utils-devel mailing list