<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129352/">https://git.reviewboard.kde.org/r/129352/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2016, 9:28 nachm. CET, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129352/diff/1/?file=484270#file484270line142" style="color: black; font-weight: bold; text-decoration: underline;">privacyfunctions.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">142</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QProcess</span><span class="o">::</span><span class="n">startDetached</span><span class="p">(</span><span class="n"><span class="hl">K</span>Standard<span class="hl">Dir</span>s</span><span class="o">::</span><span class="n">findExe</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1</span>String</span><span class="p">(</span> <span class="s">"kio_http_cache_cleaner"</span> <span class="p">)),</span><span class="n">lst</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">139</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QProcess</span><span class="o">::</span><span class="n">startDetached</span><span class="p">(</span><span class="n"><span class="hl">Q</span>Standard<span class="hl">Path</span>s</span><span class="o">::</span><span class="n">findExe<span class="hl">cutable</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">Q</span>String<span class="hl">Literal</span></span><span class="p">(</span> <span class="s">"kio_http_cache_cleaner"</span> <span class="p">)),</span><span class="n">lst</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please check if this is actually found? As far as I know, the KStandardDirs::findExe also searched the KDE libexec/ path, while Qt most certainly will not.
On my system, the actual path is /usr/lib64/libexec/kf5/kio_http_cache_cleaner
Btw, does this compile without include QStandardPaths?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point. Because the standard location for kio_http_cache_cleaner is KDE_INSTALL_LIBEXECDIR_KF5 i took the porting notes advice ("except when the executable comes from libexec, in which case the path should just be hardcoded").
QStandardPaths is already included (from an previous porting effort).</pre>
<br />
<p>- Heiko</p>
<br />
<p>On November 9th, 2016, 10:13 nachm. CET, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2016, 10:13 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sweeper
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to QStandardPaths</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Checked that kio_http_cache_cleaner --clear-all gets executed and that KBookmarkManager gets passed the actual path to konqueror's bookmarks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(05e82ef)</span></li>
<li>config-sweeper.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>privacyfunctions.cpp <span style="color: grey">(902a697)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129352/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>