[Differential] [Commented On] D1098: Add support for lzipped archives

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Mar 10 22:44:10 UTC 2016


elvisangelaccio added inline comments.

INLINE COMMENTS
  autotests/kerfuffle/createdialogtest.cpp:71 I think we should try to connect to the `currentIndexChanged` signal instead. That's the one emitted when setting the index within setCurrentFilterFromMimeType().
  kerfuffle/createdialog.cpp:311 Would be better to use `QStringLiteral("%1 (%2)\n").arg(...)` here.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1098

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list