[Differential] [Commented On] D1098: Add support for lzipped archives

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Thu Mar 10 21:58:37 UTC 2016


rthomsen added inline comments.

INLINE COMMENTS
  autotests/kerfuffle/createdialogtest.cpp:71 Yeah, there is something strange about this. When I run Ark normally and open the CreateDialog, calling setCurrentFilterFromMimeType() will emit the filterChanged() signal and hence call slotFilterChanged(). This does not happen when calling setCurrentFilterFromMimeType() from the tests and therefore I added the direct calls to slotFilterChanged() in the tests.
  
  So making setCurrentFilterFromMimeType() call slotFilterChanged() will result in slotFilterChanged() being called twice normally.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1098

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list