[Differential] [Requested Changes To] D1098: Add support for lzipped archives

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Mar 10 21:46:45 UTC 2016


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Sorry, didn't notice this earlier. We're almost done :)

INLINE COMMENTS
  autotests/kerfuffle/createdialogtest.cpp:71 This slot is now basically useless outside of CreateDialog. It makes more sense to have it called from `setCurrentFilterFromMimeType()` instead.
  This way you can remove all the calls to `slotFilterChanged(QStringLiteral(""))` in the test.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1098

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list