Review Request 123358: Fix password never being asked again after a wrong one

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123358/#review80976
-----------------------------------------------------------

Ship it!


Otherwise looks good :)


kerfuffle/cliinterface.cpp (line 539)
<https://git.reviewboard.kde.org/r/123358/#comment55468>

    "Incorrect password" should not be within <message> tags, since it's not an external message. The <message> tags are displayed literally when using the frameworks branch.


- Ragnar Thomsen


On April 14, 2015, 12:59 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123358/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 12:59 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 297820
>     http://bugs.kde.org/show_bug.cgi?id=297820
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The patch is basically the one from Romain Jarosz, plus the fixes for icons and strings as requested in the bug description.
> I'm not sure how to write a unit-test involving UI components, sorry about that.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/123358/diff/
> 
> 
> Testing
> -------
> 
> - Passwords can be entered again after typing a wrong one.
> - The icon in `KMessageBox` is always the `error` one, regardless of the context (listing or extracting).
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150530/509cbfe4/attachment.html>