Review Request 123358: Fix password never being asked again after a wrong one

Elvis Angelaccio elvis.angelaccio at kdemail.net
Sat May 30 17:19:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123358/
-----------------------------------------------------------

(Updated May 30, 2015, 5:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

Submitted with commit 8492cc21b5a45eb047109b754906a551de061065 by Ragnar Thomsen to branch frameworks.


Bugs: 297820
    http://bugs.kde.org/show_bug.cgi?id=297820


Repository: ark


Description
-------

The patch is basically the one from Romain Jarosz, plus the fixes for icons and strings as requested in the bug description.
I'm not sure how to write a unit-test involving UI components, sorry about that.


Diffs
-----

  kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
  part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 

Diff: https://git.reviewboard.kde.org/r/123358/diff/


Testing
-------

- Passwords can be entered again after typing a wrong one.
- The icon in `KMessageBox` is always the `error` one, regardless of the context (listing or extracting).


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150530/fcf41692/attachment.html>


More information about the Kde-utils-devel mailing list