Review Request 122001: Remove ellipsis from job name "Extracting file..."
Lasse Liehu
lasse.liehu at gmail.com
Sat May 30 19:04:43 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122001/
-----------------------------------------------------------
(Updated May 30, 2015, 7:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Utils and Raphael Kubo da Costa.
Changes
-------
Submitted with commit cac55e09179a55b9f31a753c321abfd9872fa4f3 by Lasse Liehu to branch master.
Repository: ark
Description
-------
In Plasma 5 ending the name in an ellipsis doesn't look good. After the job has finished, there will be a notification like this:
Extracting file...: Finished
I haven't seen other KDE applications that use an ellipsis at the end of a KIO job name.
Also this job name is used when extracting any number of files, so I changed it to plural.
Diffs
-----
app/batchextract.cpp a67c045
Diff: https://git.reviewboard.kde.org/r/122001/diff/
Testing
-------
Still works.
Thanks,
Lasse Liehu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150530/88266c95/attachment.html>
More information about the Kde-utils-devel
mailing list