Review Request 110516: Patch for "Bug 208384 - Extracting selected files will always create the whole directory structure" working with zip files

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110516/#review81248
-----------------------------------------------------------


Can you rebase this against the frameworks branch? I also suggest you use QTemporaryDir.

- Ragnar Thomsen


On May 19, 2013, 9:11 a.m., Francesc Ortiz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110516/
> -----------------------------------------------------------
> 
> (Updated May 19, 2013, 9:11 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 208384
>     http://bugs.kde.org/show_bug.cgi?id=208384
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> 1 - If a cliplugin does not support "rootNode" (it didn't provide "$RootNodeSwitch" extra argument) and one is provided, a random temporary directory is created under the destination directory as long as a root node is provided.
> 2 - The selected files get extracted under this temporary directory.
> 3 - Then the extracted files are moved from the temporary directory to the destinarion directory, honoring "rootNode".
> 4 - Finally, the temporary directory gets removed.
> 
> PS: Extracting using the extract button still creates the whole directory structure, I assume that it is is intentional in the existing code.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.cpp 3cbe31b 
> 
> Diff: https://git.reviewboard.kde.org/r/110516/diff/
> 
> 
> Testing
> -------
> 
> Since All the code I wrote belongs to "CliInterface::copyFiles" I only tested extractions.
> 
> The tests where run with zip, rar and 7z files:
> - Drag a file from ark into a dolphin window.
> - Drag a directory containing files from ark into a dolphin window.
> - All 3 contextual menu options for ark.
> - Extraction with the extract button both preserving paths and flattening the directory structure, and also enabling and disabling the extract to subfolder option.
> 
> 
> Thanks,
> 
> Francesc Ortiz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150605/a0e01d8f/attachment.html>