<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110516/">https://git.reviewboard.kde.org/r/110516/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you rebase this against the frameworks branch? I also suggest you use QTemporaryDir.</p></pre>
<br />
<p>- Ragnar Thomsen</p>
<br />
<p>On May 19th, 2013, 9:11 a.m. CEST, Francesc Ortiz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Francesc Ortiz.</div>
<p style="color: grey;"><i>Updated May 19, 2013, 9:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=208384">208384</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1 - If a cliplugin does not support "rootNode" (it didn't provide "$RootNodeSwitch" extra argument) and one is provided, a random temporary directory is created under the destination directory as long as a root node is provided.
2 - The selected files get extracted under this temporary directory.
3 - Then the extracted files are moved from the temporary directory to the destinarion directory, honoring "rootNode".
4 - Finally, the temporary directory gets removed.
PS: Extracting using the extract button still creates the whole directory structure, I assume that it is is intentional in the existing code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since All the code I wrote belongs to "CliInterface::copyFiles" I only tested extractions.
The tests where run with zip, rar and 7z files:
- Drag a file from ark into a dolphin window.
- Drag a directory containing files from ark into a dolphin window.
- All 3 contextual menu options for ark.
- Extraction with the extract button both preserving paths and flattening the directory structure, and also enabling and disabling the extract to subfolder option.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(3cbe31b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110516/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>