Review Request 117467: Archive type detection

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117467/#review81296
-----------------------------------------------------------


Ark in frameworks branch uses QMimeDatabase::mimeTypeForFile(filename). The second parameter of this function is omitted but defaults to QMimeDatabase::MatchDefault, which according to the Qt documentation uses both content and extension to identify the mimetype.

I tested by renaming a .zip file to a .txt, and Ark identified the mimetype correctly as application/zip.

Can we please close this review request now?

- Ragnar Thomsen


On April 10, 2014, 9:59 a.m., Ondřej Záruba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117467/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 9:59 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 245705
>     http://bugs.kde.org/show_bug.cgi?id=245705
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ark tests the archive type just by file name, which is not enough. This patch forces Ark to detect file type by its content.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive.cpp c2c5b18 
> 
> Diff: https://git.reviewboard.kde.org/r/117467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ondřej Záruba
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150607/02d42e2c/attachment.html>