Review Request 120204: Create password-protected archives with Ark

[Elvis Angelaccio]

> On Lug. 21, 2015, 9:39 p.m., Raphael Kubo da Costa wrote:
> > kerfuffle/archive_kerfuffle.cpp, line 360
> > <https://git.reviewboard.kde.org/r/120204/diff/9/?file=385639#file385639line360>
> >
> >     What if you just assign use `offers.constBegin()` and `offers.constEnd()` here directly?

That code was copy-pasted. Now there is a `foreach` loop.


> On Lug. 21, 2015, 9:39 p.m., Raphael Kubo da Costa wrote:
> > kerfuffle/cliinterface.cpp, line 289
> > <https://git.reviewboard.kde.org/r/120204/diff/9/?file=385643#file385643line289>
> >
> >     You should probably `Q_ASSERT` on `PasswordHeaderSwitch` too.

This would break the encryption with the 7z plugin: `isHeaderEncryptionEnabled()` would return true but then `Q_ASSERT` on `PasswordHeaderSwitch` would fail, because the 7z plugin relies on the `EncryptHeaderSwitch` key instead of `PasswordHeaderSwitch`.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review82790
-----------------------------------------------------------


On Lug. 22, 2015, 11:13 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated Lug. 22, 2015, 11:13 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 6511d548e0657f670c3823f63b13c4ca4fa98036 
>   kerfuffle/CMakeLists.txt 8d118033571b447f6ce09140417f25abcf9d2f79 
>   kerfuffle/adddialog.h 217da1e44d19d869f052aaeab640000a4ea4051c 
>   kerfuffle/adddialog.cpp 45aed46404a9f5317220112d4c9093066d81535c 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   kerfuffle/addtoarchive.h a5bdebad03262f993b97c2dfec75796f15c0b8e1 
>   kerfuffle/addtoarchive.cpp 6a63839948cd435f04f5dda84b93ebbb52fd4f52 
>   kerfuffle/archive_kerfuffle.h 886da3eb437cb75442b747223784315abbac1c92 
>   kerfuffle/archive_kerfuffle.cpp c22d61e0dd72779d7fb64658cc58db7884979455 
>   kerfuffle/archiveinterface.h 968237d8c09e81ffc39a2e63b0b5f320383df9b7 
>   kerfuffle/archiveinterface.cpp 686dc060b7e5d84fdaa000aa5c1305ede5a82e73 
>   kerfuffle/cliinterface.h e93d443d18885c861212edd2d8275852a1ece568 
>   kerfuffle/cliinterface.cpp 2718c11dd2f9472b43f5a17d61d6d578616fdfbb 
>   kerfuffle/createdialog.h PRE-CREATION 
>   kerfuffle/createdialog.cpp PRE-CREATION 
>   kerfuffle/createdialog.ui PRE-CREATION 
>   kerfuffle/kerfufflePlugin.desktop 7c194af133e2789a9f2997367c93e68b2c2d6f91 
>   part/archivemodel.h 13e062d683e53d47bb2a0309a9739190e03581ce 
>   part/archivemodel.cpp fd70705d67898120053840541124f092e023e4db 
>   part/part.cpp 9cd27804f633323b7dca9baf4c232754af8ef1b8 
>   plugins/cli7zplugin/cliplugin.cpp 1c1389f31556669515994a95d59b06ee95726b09 
>   plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake b9325f9a765e6d1ba38e666d7eac6e9e34bf0bcb 
>   plugins/clirarplugin/cliplugin.cpp 489abd6c1b918e5b87e358e08748703992dfe64b 
>   plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 545dca99af5608d10ffe05d5557a5baf92d4b0d1 
>   plugins/clizipplugin/cliplugin.cpp c927581c30a5dd5072cff92e8d0f68e43cd6c588 
>   plugins/clizipplugin/kerfuffle_clizip.desktop.cmake d7451c7b6f045832b1b79f8628eca7491782cc99 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> File Attachments
> ----------------
> 
> passwd-dialog-0.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png
> passwd-dialog-1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png
> passwd-dialog-2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png
> passwd-dialog-3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png
> show-password.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png
> passwd-dialog-4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/09/721a1c06-9cb7-4e6d-a42a-bded5120e4c1__passwd-dialog-4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150722/37b10236/attachment-0001.html>