Review Request 120204: Create password-protected archives with Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review82790
-----------------------------------------------------------



app/mainwindow.cpp (line 293)
<https://git.reviewboard.kde.org/r/120204/#comment57106>

    `ret` is not being used anywhere other than the `if` below, so you can just use `if (dialog.data()->exec())` directly.



kerfuffle/adddialog.h (line 32)
<https://git.reviewboard.kde.org/r/120204/#comment57107>

    Are you sure you need `kerfuffle/` here?



kerfuffle/archive_kerfuffle.cpp (line 358)
<https://git.reviewboard.kde.org/r/120204/#comment57109>

    How about a `QSet` so you don't have to call `QStringList::contains()` down there?



kerfuffle/archive_kerfuffle.cpp (line 360)
<https://git.reviewboard.kde.org/r/120204/#comment57108>

    What if you just assign use `offers.constBegin()` and `offers.constEnd()` here directly?



kerfuffle/archive_kerfuffle.cpp (lines 385 - 387)
<https://git.reviewboard.kde.org/r/120204/#comment57110>

    The same comments also apply here.



kerfuffle/cliinterface.h (lines 225 - 229)
<https://git.reviewboard.kde.org/r/120204/#comment57112>

    This all looks copy-pasted.



kerfuffle/cliinterface.cpp (line 289)
<https://git.reviewboard.kde.org/r/120204/#comment57113>

    You should probably `Q_ASSERT` on `PasswordHeaderSwitch` too.



kerfuffle/createdialog.h (lines 56 - 59)
<https://git.reviewboard.kde.org/r/120204/#comment57114>

    `const`?


- Raphael Kubo da Costa


On July 16, 2015, 12:40 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 12:40 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp aee823174a0b731e125381be09181938cdb6dd7d 
>   kerfuffle/CMakeLists.txt 8c56b4f46090c924f0848ad229b6a3779af1f1f3 
>   kerfuffle/adddialog.h 7c9f03e916da3a410482be2b45ff30923dfc1f9f 
>   kerfuffle/adddialog.cpp 2950ee6e22c90c770bb3b9128243f9786989ee52 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   kerfuffle/addtoarchive.h fa4608e0c0df9ea9cec3aa9e7323fb53dd1b12d3 
>   kerfuffle/addtoarchive.cpp d13e0958468e3bb1aa85606e4fd4d3cb8ef6d3c0 
>   kerfuffle/archive_kerfuffle.h 515788f978c1d29146c25dcb57a9dad2d46371f7 
>   kerfuffle/archive_kerfuffle.cpp c2c5b18528def63405a8703475b1c592ca945973 
>   kerfuffle/archiveinterface.h 801318b7842d78a0de54700ffdb43a945f513fbf 
>   kerfuffle/archiveinterface.cpp 3319de074225ccf8cb0fe54ffadca5882cf29342 
>   kerfuffle/cliinterface.h b4d79ed2f3ffbbbe28f7087f1fbff36de5138f36 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   kerfuffle/createdialog.h PRE-CREATION 
>   kerfuffle/createdialog.cpp PRE-CREATION 
>   kerfuffle/createdialog.ui PRE-CREATION 
>   kerfuffle/kerfufflePlugin.desktop 3999d24f414ede1bb377f47b8c7d46dc44459b7d 
>   part/archivemodel.h 7f8c527fc331778e0ec74dce047eba5c56507499 
>   part/archivemodel.cpp 43262689ad989e3a9233e279db6dcd532084a031 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
>   plugins/cli7zplugin/cliplugin.cpp 500f121de97ef395110658a6ca495298bc797b46 
>   plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake 29b355af72b02d767e099a6e7a61778a70ae4476 
>   plugins/clirarplugin/cliplugin.cpp f5f7b184cb9f7ee16efd74968f2e86dc83668b4d 
>   plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 3091d9d384952fbe27a43049c66c2ee998017957 
>   plugins/clizipplugin/cliplugin.cpp 1be2a10f722865c23fba6df5c25993742ce38d69 
>   plugins/clizipplugin/kerfuffle_clizip.desktop.cmake 32ceced7b913c4d4a0d2007b4b3ea7b4ec850e35 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> File Attachments
> ----------------
> 
> passwd-dialog-0.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png
> passwd-dialog-1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png
> passwd-dialog-2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png
> passwd-dialog-3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png
> show-password.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png
> passwd-dialog-4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/09/721a1c06-9cb7-4e6d-a42a-bded5120e4c1__passwd-dialog-4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150721/073cd3b5/attachment-0001.html>