<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120204/">https://git.reviewboard.kde.org/r/120204/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On luglio 21st, 2015, 9:39 p.m. UTC, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120204/diff/9/?file=385639#file385639line360" style="color: black; font-weight: bold; text-decoration: underline;">kerfuffle/archive_kerfuffle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">360</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span class="p">(;</span> <span class="n">it</span> <span class="o">!=</span> <span class="n">itEnd</span><span class="p">;</span> <span class="o">++</span><span class="n">it</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What if you just assign use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">offers.constBegin()</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">offers.constEnd()</code> here directly?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That code was copy-pasted. Now there is a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">foreach</code> loop.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On luglio 21st, 2015, 9:39 p.m. UTC, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120204/diff/9/?file=385643#file385643line289" style="color: black; font-weight: bold; text-decoration: underline;">kerfuffle/cliinterface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool CliInterface::addFiles(const QStringList & files, const CompressionOptions& options)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">289</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">isHeaderEncryptionEnabled</span><span class="p">()</span> <span class="o">&&</span> <span class="o">!</span><span class="n">m_param</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">PasswordHeaderSwitch</span><span class="p">).</span><span class="n">toStringList</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You should probably <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_ASSERT</code> on <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">PasswordHeaderSwitch</code> too.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This would break the encryption with the 7z plugin: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">isHeaderEncryptionEnabled()</code> would return true but then <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_ASSERT</code> on <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">PasswordHeaderSwitch</code> would fail, because the 7z plugin relies on the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EncryptHeaderSwitch</code> key instead of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">PasswordHeaderSwitch</code>.</p></pre>
<br />
<p>- Elvis</p>
<br />
<p>On luglio 22nd, 2015, 11:13 a.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Lug. 22, 2015, 11:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=253694">253694</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch allows the users to create password-protected archives using Ark.
The supported plugins are <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">zip</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7z</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">rar</code>.
The input fields for the passwords are displayed only when the relevent mime filters are selected in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">AddDialog</code> window.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Create <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.zip</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.7z</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.rar</code> archives using the Ark <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">AddDialog</code> dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
Those archives are created as expected and their entries are marked as <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Password protected</em>.
If the user clicks on those entries, the standard password dialog is prompted to the user.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.cpp <span style="color: grey">(6511d548e0657f670c3823f63b13c4ca4fa98036)</span></li>
<li>kerfuffle/CMakeLists.txt <span style="color: grey">(8d118033571b447f6ce09140417f25abcf9d2f79)</span></li>
<li>kerfuffle/adddialog.h <span style="color: grey">(217da1e44d19d869f052aaeab640000a4ea4051c)</span></li>
<li>kerfuffle/adddialog.cpp <span style="color: grey">(45aed46404a9f5317220112d4c9093066d81535c)</span></li>
<li>kerfuffle/adddialog.ui <span style="color: grey">(a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1)</span></li>
<li>kerfuffle/addtoarchive.h <span style="color: grey">(a5bdebad03262f993b97c2dfec75796f15c0b8e1)</span></li>
<li>kerfuffle/addtoarchive.cpp <span style="color: grey">(6a63839948cd435f04f5dda84b93ebbb52fd4f52)</span></li>
<li>kerfuffle/archive_kerfuffle.h <span style="color: grey">(886da3eb437cb75442b747223784315abbac1c92)</span></li>
<li>kerfuffle/archive_kerfuffle.cpp <span style="color: grey">(c22d61e0dd72779d7fb64658cc58db7884979455)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: grey">(968237d8c09e81ffc39a2e63b0b5f320383df9b7)</span></li>
<li>kerfuffle/archiveinterface.cpp <span style="color: grey">(686dc060b7e5d84fdaa000aa5c1305ede5a82e73)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: grey">(e93d443d18885c861212edd2d8275852a1ece568)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(2718c11dd2f9472b43f5a17d61d6d578616fdfbb)</span></li>
<li>kerfuffle/createdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/kerfufflePlugin.desktop <span style="color: grey">(7c194af133e2789a9f2997367c93e68b2c2d6f91)</span></li>
<li>part/archivemodel.h <span style="color: grey">(13e062d683e53d47bb2a0309a9739190e03581ce)</span></li>
<li>part/archivemodel.cpp <span style="color: grey">(fd70705d67898120053840541124f092e023e4db)</span></li>
<li>part/part.cpp <span style="color: grey">(9cd27804f633323b7dca9baf4c232754af8ef1b8)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(1c1389f31556669515994a95d59b06ee95726b09)</span></li>
<li>plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake <span style="color: grey">(b9325f9a765e6d1ba38e666d7eac6e9e34bf0bcb)</span></li>
<li>plugins/clirarplugin/cliplugin.cpp <span style="color: grey">(489abd6c1b918e5b87e358e08748703992dfe64b)</span></li>
<li>plugins/clirarplugin/kerfuffle_clirar.desktop.cmake <span style="color: grey">(545dca99af5608d10ffe05d5557a5baf92d4b0d1)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(c927581c30a5dd5072cff92e8d0f68e43cd6c588)</span></li>
<li>plugins/clizipplugin/kerfuffle_clizip.desktop.cmake <span style="color: grey">(d7451c7b6f045832b1b79f8628eca7491782cc99)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120204/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png">passwd-dialog-0.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png">passwd-dialog-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png">passwd-dialog-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png">passwd-dialog-3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png">show-password.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/09/721a1c06-9cb7-4e6d-a42a-bded5120e4c1__passwd-dialog-4.png">passwd-dialog-4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>