Review Request 114658: Fixes the data loss caused when user closes kwalletmanager with unsaved changes

[Arjun Ak]

> On Dec. 25, 2013, 5:09 p.m., Valentin Rusu wrote:
> > src/manager/kwalletmanager.cpp, line 176
> > <https://git.reviewboard.kde.org/r/114658/diff/1/?file=227140#file227140line176>
> >
> >     Little formal nitpick: could you please let the opening brace on line 176.

Isnt the opening brace supposed to be in another line?


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114658/#review46146
-----------------------------------------------------------


On Dec. 25, 2013, 6:31 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114658/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2013, 6:31 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 329165
>     http://bugs.kde.org/show_bug.cgi?id=329165
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)
> 
> 
> Diffs
> -----
> 
>   src/manager/kwalleteditor.h f3d08f3 
>   src/manager/kwalleteditor.cpp 6f07b7d 
>   src/manager/kwalletmanager.h 7489077 
>   src/manager/kwalletmanager.cpp 355fda7 
>   src/manager/kwalletmanagerwidget.h df1e4fa 
>   src/manager/kwalletmanagerwidget.cpp c855c91 
>   src/manager/kwalletmanagerwidgetitem.h ad2451e 
>   src/manager/kwalletmanagerwidgetitem.cpp 79bb476 
>   src/manager/walletcontrolwidget.h fb94999 
>   src/manager/walletcontrolwidget.cpp 948cc60 
> 
> Diff: https://git.reviewboard.kde.org/r/114658/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20131225/1fefca56/attachment.html>