<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114658/">https://git.reviewboard.kde.org/r/114658/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 25th, 2013, 5:09 p.m. IST, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114658/diff/1/?file=227140#file227140line176" style="color: black; font-weight: bold; text-decoration: underline;">src/manager/kwalletmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KWalletManager::~KWalletManager() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">KWalletManager</span><span class="o">::</span><span class="n">queryClose</span><span class="p">()</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">KWalletManager</span><span class="o">::</span><span class="n">queryClose</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Little formal nitpick: could you please let the opening brace on line 176.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isnt the opening brace supposed to be in another line?</pre>
<br />
<p>- Arjun</p>
<br />
<p>On December 25th, 2013, 6:31 p.m. IST, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Dec. 25, 2013, 6:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=329165">329165</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/manager/kwalleteditor.h <span style="color: grey">(f3d08f3)</span></li>
<li>src/manager/kwalleteditor.cpp <span style="color: grey">(6f07b7d)</span></li>
<li>src/manager/kwalletmanager.h <span style="color: grey">(7489077)</span></li>
<li>src/manager/kwalletmanager.cpp <span style="color: grey">(355fda7)</span></li>
<li>src/manager/kwalletmanagerwidget.h <span style="color: grey">(df1e4fa)</span></li>
<li>src/manager/kwalletmanagerwidget.cpp <span style="color: grey">(c855c91)</span></li>
<li>src/manager/kwalletmanagerwidgetitem.h <span style="color: grey">(ad2451e)</span></li>
<li>src/manager/kwalletmanagerwidgetitem.cpp <span style="color: grey">(79bb476)</span></li>
<li>src/manager/walletcontrolwidget.h <span style="color: grey">(fb94999)</span></li>
<li>src/manager/walletcontrolwidget.cpp <span style="color: grey">(948cc60)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114658/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>