Review Request 114658: Fixes the data loss caused when user closes kwalletmanager with unsaved changes
Valentin Rusu
kde at rusu.info
Wed Dec 25 11:39:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114658/#review46146
-----------------------------------------------------------
Here are some small changes I would recommend.
src/manager/kwalleteditor.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32955>
Extrace space to be deleted.
src/manager/kwalleteditor.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32956>
Extra space to be deleted
src/manager/kwalletmanager.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32954>
Little formal nitpick: could you please let the opening brace on line 176.
src/manager/kwalletmanager.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32957>
Maybe it would be better to not specify the title, so the title will be consistent with the other message boxes.
src/manager/kwalletmanagerwidget.h
<https://git.reviewboard.kde.org/r/114658/#comment32958>
I would also add the const qualifier for this method, as it doesn't change object's state.
src/manager/kwalletmanagerwidget.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32959>
const qualifier for this method - see comment above
src/manager/kwalletmanagerwidgetitem.h
<https://git.reviewboard.kde.org/r/114658/#comment32960>
const qualifier - see comment above>
src/manager/kwalletmanagerwidgetitem.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32961>
const qualifier - see comment above
src/manager/walletcontrolwidget.h
<https://git.reviewboard.kde.org/r/114658/#comment32962>
const qualifier - see comment above
src/manager/walletcontrolwidget.cpp
<https://git.reviewboard.kde.org/r/114658/#comment32963>
const qualifier - see comment above
- Valentin Rusu
On Dec. 25, 2013, 5:50 a.m., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114658/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2013, 5:50 a.m.)
>
>
> Review request for KDE Utils.
>
>
> Bugs: 329165
> http://bugs.kde.org/show_bug.cgi?id=329165
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)
>
>
> Diffs
> -----
>
> src/manager/kwalletmanager.h 7489077
> src/manager/kwalletmanager.cpp 355fda7
> src/manager/kwalleteditor.cpp 6f07b7d
> src/manager/kwalleteditor.h f3d08f3
> src/manager/kwalletmanagerwidget.h df1e4fa
> src/manager/kwalletmanagerwidget.cpp c855c91
> src/manager/kwalletmanagerwidgetitem.h ad2451e
> src/manager/kwalletmanagerwidgetitem.cpp 79bb476
> src/manager/walletcontrolwidget.h fb94999
> src/manager/walletcontrolwidget.cpp 948cc60
>
> Diff: https://git.reviewboard.kde.org/r/114658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20131225/96104706/attachment.html>
More information about the Kde-utils-devel
mailing list