Review Request 109953: Fix of Ark::Part::openFile().

[Alexandr Akulich]

> On April 26, 2013, 4:28 p.m., Raphael Kubo da Costa wrote:
> > Nice catch, thanks very much for the patch! After implementing the suggestion I mention, it's good to go. Do you already have a commit account?

I haven't write-access yet. I upload new patch in commit-over-email format.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109953/#review31613
-----------------------------------------------------------


On April 27, 2013, 3:37 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109953/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 3:37 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> End of Ark::Part::openFile() operate with "QScopedPointer<Kerfuffle::Archive> archive" in old way (Kerfuffle::Archive *archive). Checking "archive" after "archive.take()" leads in bug.
> 
> 
> This addresses bug 318306.
>     http://bugs.kde.org/show_bug.cgi?id=318306
> 
> 
> Diffs
> -----
> 
>   part/part.cpp d806262 
> 
> Diff: http://git.reviewboard.kde.org/r/109953/diff/
> 
> 
> Testing
> -------
> 
> Since file opened or created, window title reflected it as expected. Futhermore, "Open Recent" menu now works properly.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130427/4d3a7ab7/attachment.html>