Review Request 109953: Fix of Ark::Part::openFile().

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109953/#review31613
-----------------------------------------------------------


Nice catch, thanks very much for the patch! After implementing the suggestion I mention, it's good to go. Do you already have a commit account?


part/part.cpp
<http://git.reviewboard.kde.org/r/109953/#comment23531>

    It looks like the checks for archive != 0 are not needed anymore: we already check if archive is 0 a few lines above and return if that's the case.
    
    Please remove the first check as it is not needed these days.



part/part.cpp
<http://git.reviewboard.kde.org/r/109953/#comment23532>

    Please just return true here.


- Raphael Kubo da Costa


On April 14, 2013, 9:36 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109953/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 9:36 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> End of Ark::Part::openFile() operate with "QScopedPointer<Kerfuffle::Archive> archive" in old way (Kerfuffle::Archive *archive). Checking "archive" after "archive.take()" leads in bug.
> 
> 
> This addresses bug 318306.
>     http://bugs.kde.org/show_bug.cgi?id=318306
> 
> 
> Diffs
> -----
> 
>   part/part.cpp d806262bf9eb44a50295298f9304b7f4dfe41732 
> 
> Diff: http://git.reviewboard.kde.org/r/109953/diff/
> 
> 
> Testing
> -------
> 
> Since file opened or created, window title reflected it as expected. Futhermore, "Open Recent" menu now works properly.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130426/775d0d5e/attachment.html>