Review Request 109953: Fix of Ark::Part::openFile().

Alexandr Akulich akulichalexander at gmail.com
Sat Apr 27 09:37:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109953/
-----------------------------------------------------------

(Updated April 27, 2013, 3:37 p.m.)


Review request for KDE Utils.


Changes
-------

Get rid useless checks.


Description
-------

End of Ark::Part::openFile() operate with "QScopedPointer<Kerfuffle::Archive> archive" in old way (Kerfuffle::Archive *archive). Checking "archive" after "archive.take()" leads in bug.


This addresses bug 318306.
    http://bugs.kde.org/show_bug.cgi?id=318306


Diffs (updated)
-----

  part/part.cpp d806262 

Diff: http://git.reviewboard.kde.org/r/109953/diff/


Testing
-------

Since file opened or created, window title reflected it as expected. Futhermore, "Open Recent" menu now works properly.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130427/b38250ef/attachment.html>


More information about the Kde-utils-devel mailing list