Review Request: avoid a crash when the opened archive is moved

Jaime Torres Amate jtamate at gmail.com
Sun Oct 14 10:07:45 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106842/
-----------------------------------------------------------

Review request for KDE Utils.


Description
-------

all emit error in libarchivehandler.cpp use only one argument, therefore, the signal is not the same as the one declared.
Fortunately, those hard to avoid mistakes will be gone with Qt5. 


Diffs
-----

  kerfuffle/jobs.h d704dfc 

Diff: http://git.reviewboard.kde.org/r/106842/diff/


Testing
-------

open with ark a .tar.gz file, move the opened .tar.gz file. try to preview any file of the opened .tar.gz.
without the patch, crash.
with the patch, the expected error message.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20121014/7afcc358/attachment.html>


More information about the Kde-utils-devel mailing list