Review Request: KCalc Backspace Button

[Raphael Kubo da Costa]

> On April 17, 2012, 4:37 p.m., Evan Teran wrote:
> > I've actually already added a backspace button the the 4.8 branch in GIT. So I'm going to have to reject this patch. However, you used a much better icon for the button, so I'll be using that for the button text :-).
> 
> Raphael Kubo da Costa wrote:
>     Technically you should coordinate with the translation team first, since this changes a translatable string, right?
> 
> Reshad Patuck wrote:
>     @Evan My Bad, I looked at master and didn't see the function, my first time working on KDE, gotta start looking at the 4.8 branch for all projects form now on.
>     
>     @Raphael The string used for the backspace is a generic left arrow (? unicode 0x2190) so don't think it need any translation. That said its my first time submitting anything to KDE and don't know weather it needs to be sent to the translation team.

My comment was for Evan; his commit f654046c8ba6aede9f464494765bea7c8f289ca5 changed a string in a stable branch.

In general, looking at the master branch is OK, it just happened that Evan has been committing to KDE/4.8 and has not merged those changes into master yet. Thanks for your contribution, and we look forward for your next patches :-)


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104604/#review12586
-----------------------------------------------------------


On April 15, 2012, 10:19 a.m., Reshad Patuck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104604/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 10:19 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Added a backspace button to KCalc so as to make it easier when using the mouse to enter data.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=204782.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=204782
> 
> 
> Diffs
> -----
> 
>   kcalc.h 38b3036 
>   kcalc.cpp 9cfdfcf 
>   kcalc.ui 4f2f1e5 
>   kcalcdisplay.h 84c1908 
>   kcalcdisplay.cpp fdc1140 
> 
> Diff: http://git.reviewboard.kde.org/r/104604/diff/
> 
> 
> Testing
> -------
> 
> Unit testing on the backspace buttons functionality, Integration testing when using it along with multiple other functions.
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://git.reviewboard.kde.org/r/104604/s/534/
> 
> 
> Thanks,
> 
> Reshad Patuck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120417/58e7137e/attachment-0001.html>