Review Request: Fix a crash in Ark

Nathan Mills nn.dm55 at gmail.com
Mon Apr 16 21:38:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104623/
-----------------------------------------------------------

(Updated April 16, 2012, 9:38 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

Added the group kdeutils.


Description
-------

This patch fixes a crash in Ark when Ark is closed while loading a big archive by ensuring that Archive::m_iface is always the last child of Archive so that it gets deleted last. Otherwise, a Job tries to call methods on a deleted ReadOnlyArchiveInterface and the program crashes.


This addresses bug 193908.
    http://bugs.kde.org/show_bug.cgi?id=193908


Diffs
-----

  kerfuffle/archive.h 515788f 
  kerfuffle/archive.cpp c2c5b18 

Diff: http://git.reviewboard.kde.org/r/104623/diff/


Testing
-------


Thanks,

Nathan Mills

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120416/d6c599e9/attachment.html>


More information about the Kde-utils-devel mailing list