<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104604/">http://git.reviewboard.kde.org/r/104604/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2012, 4:37 p.m., <b>Evan Teran</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've actually already added a backspace button the the 4.8 branch in GIT. So I'm going to have to reject this patch. However, you used a much better icon for the button, so I'll be using that for the button text :-).</pre>
</blockquote>
<p>On April 17th, 2012, 5:02 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Technically you should coordinate with the translation team first, since this changes a translatable string, right?</pre>
</blockquote>
<p>On April 17th, 2012, 5:22 p.m., <b>Reshad Patuck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Evan My Bad, I looked at master and didn't see the function, my first time working on KDE, gotta start looking at the 4.8 branch for all projects form now on.
@Raphael The string used for the backspace is a generic left arrow (? unicode 0x2190) so don't think it need any translation. That said its my first time submitting anything to KDE and don't know weather it needs to be sent to the translation team.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My comment was for Evan; his commit f654046c8ba6aede9f464494765bea7c8f289ca5 changed a string in a stable branch.
In general, looking at the master branch is OK, it just happened that Evan has been committing to KDE/4.8 and has not merged those changes into master yet. Thanks for your contribution, and we look forward for your next patches :-)</pre>
<br />
<p>- Raphael</p>
<br />
<p>On April 15th, 2012, 10:19 a.m., Reshad Patuck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Reshad Patuck.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 10:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a backspace button to KCalc so as to make it easier when using the mouse to enter data.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit testing on the backspace buttons functionality, Integration testing when using it along with multiple other functions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=204782">https://bugs.kde.org/show_bug.cgi?id=204782</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcalc.h <span style="color: grey">(38b3036)</span></li>
<li>kcalc.cpp <span style="color: grey">(9cfdfcf)</span></li>
<li>kcalc.ui <span style="color: grey">(4f2f1e5)</span></li>
<li>kcalcdisplay.h <span style="color: grey">(84c1908)</span></li>
<li>kcalcdisplay.cpp <span style="color: grey">(fdc1140)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104604/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104604/s/534/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/KCalc_Snapshot1_400x100.png" style="border: 1px black solid;" alt="Screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>