<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5761/">http://svn.reviewboard.kde.org/r/5761/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 17th, 2011, 5:26 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, I hope you are still there :)
The patch looks fine overall, but the coding style is very inconsistent. In Ark we follow kdelibs' coding style, it might be good for you to take a look at it [1]. And please make sure there is no trailing whitespace in the code.
[1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, and I would be really happy if you could add some unit tests, at least for the list/extraction case. You could add a small sample file and use $KDEHOME (use KStandardDirs to get it) or a temporary directory as the extraction directory.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On November 2nd, 2010, 2:22 p.m., George Metaxas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeutils.</div>
<div>By George Metaxas.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2010, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented lzh/lha support in ark. Most of the required actions work file. However, the lha utility (http://lha.sourceforge.jp) does not like being used by another process. For example, if it has to overwrite a file, it simply skips it, when it is not being run at the terminal. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the following cases:
- Create a new archive
- Add files and/or directories to an archive
- Delete files and/or directories from an archive
- Extract files and/or directories from an archive
- Preview files from an archive.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=231896">231896</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeutils/ark/plugins/CMakeLists.txt <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clilhaplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clilhaplugin/cliplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clilhaplugin/cliplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clilhaplugin/kerfuffle_clilha.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>