Review Request: ksecrets build fix

Johannes Huber johu at gmx.de
Fri Dec 23 08:49:46 UTC 2011



> On Dec. 22, 2011, 12:45 a.m., Johannes Huber wrote:
> > Ship It!
> 
> Raphael Kubo da Costa wrote:
>     What does "ship it" in your own request mean? :) Do you have an account or do you need someone to commit the patch for you?

Yes, somebody have to commit the patch. Because my developer application is not applied yet.


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103487/#review9155
-----------------------------------------------------------


On Dec. 21, 2011, 2:50 p.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103487/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 2:50 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Build fix for ksecrets. Use the correct include for QtCrypto. 
> 
> Note: In CMakeLists.txt libssh2 is missing, this should be fixed too.
> 
> 
> Diffs
> -----
> 
>   ksecretsserviced/backend/backendcollection.h 7ddb4dd 
>   ksecretsserviced/backend/backenditem.h d3f3857 
>   ksecretsserviced/backend/securebuffer.h 2a9cb46 
>   ksecretsserviced/backend/tests/securebuffertest.h 27c7f97 
>   ksecretsserviced/frontend/secret/adaptors/daemonsecret.h 4e8976e 
>   ksecretsserviced/frontend/secret/session.h c42e0f0 
>   ksecretsserviced/frontend/tests/servicetest.cpp d84e7b6 
>   ksecretsserviced/jobinfostructs.h 49cdb40 
>   ksecretsserviced/main.cpp f13a798 
>   ksecretsserviced/ui/abstractuijobs.h 796676b 
>   ksecretsserviced/ui/tests/dialogaskaclprefstest.cpp 072ffa0 
>   ksecretsserviced/ui/tests/dialoguimanagertest.cpp d187ce9 
>   ksecretsserviced/ui/tests/nouimanagertest.cpp 5fa90ef 
>   secretsync/main.cpp c2f8a53 
> 
> Diff: http://git.reviewboard.kde.org/r/103487/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111223/c414866c/attachment.html>


More information about the Kde-utils-devel mailing list