<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103487/">http://git.reviewboard.kde.org/r/103487/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 22nd, 2011, 12:45 a.m., <b>Johannes Huber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On December 23rd, 2011, 12:28 a.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What does "ship it" in your own request mean? :) Do you have an account or do you need someone to commit the patch for you?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, somebody have to commit the patch. Because my developer application is not applied yet.</pre>
<br />
<p>- Johannes</p>
<br />
<p>On December 21st, 2011, 2:50 p.m., Johannes Huber wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Johannes Huber.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2011, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build fix for ksecrets. Use the correct include for QtCrypto.
Note: In CMakeLists.txt libssh2 is missing, this should be fixed too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksecretsserviced/backend/backendcollection.h <span style="color: grey">(7ddb4dd)</span></li>
<li>ksecretsserviced/backend/backenditem.h <span style="color: grey">(d3f3857)</span></li>
<li>ksecretsserviced/backend/securebuffer.h <span style="color: grey">(2a9cb46)</span></li>
<li>ksecretsserviced/backend/tests/securebuffertest.h <span style="color: grey">(27c7f97)</span></li>
<li>ksecretsserviced/frontend/secret/adaptors/daemonsecret.h <span style="color: grey">(4e8976e)</span></li>
<li>ksecretsserviced/frontend/secret/session.h <span style="color: grey">(c42e0f0)</span></li>
<li>ksecretsserviced/frontend/tests/servicetest.cpp <span style="color: grey">(d84e7b6)</span></li>
<li>ksecretsserviced/jobinfostructs.h <span style="color: grey">(49cdb40)</span></li>
<li>ksecretsserviced/main.cpp <span style="color: grey">(f13a798)</span></li>
<li>ksecretsserviced/ui/abstractuijobs.h <span style="color: grey">(796676b)</span></li>
<li>ksecretsserviced/ui/tests/dialogaskaclprefstest.cpp <span style="color: grey">(072ffa0)</span></li>
<li>ksecretsserviced/ui/tests/dialoguimanagertest.cpp <span style="color: grey">(d187ce9)</span></li>
<li>ksecretsserviced/ui/tests/nouimanagertest.cpp <span style="color: grey">(5fa90ef)</span></li>
<li>secretsync/main.cpp <span style="color: grey">(c2f8a53)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>