Review Request: use FileSize type for humanReadableSize() parameter

[Anssi Hannula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102870/
-----------------------------------------------------------

(Updated Dec. 21, 2011, 7:36 p.m.)


Review request for KDE Utils.


Changes
-------

Updated Summary and Description to reflect better what the patch actually does on current git master, as per previous discussion.


Summary (updated)
-----------------

use FileSize type for humanReadableSize() parameter


Description (updated)
-------

Filelight internally uses a FileSize type in fileTree.h to represent
file sizes. However, File::humanReadableSize() takes the size as uint
instead of FileSize, causing overflow issues if FileSize is defined
as larger than uint.


Diffs
-----

  src/part/fileTree.h fe0a9ec 
  src/part/fileTree.cpp 6da7a8f 

Diff: http://git.reviewboard.kde.org/r/102870/diff/diff


Testing (updated)
-------

Built filelight in kdeutils-4.6.5 and git master with this change and it caused no issues.


Thanks,

Anssi Hannula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111221/9a88f841/attachment.html>