Review Request: fix wrap-around with partitions over 4 TB by using a 64-bit counter

[Anssi Hannula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103496/
-----------------------------------------------------------

Review request for KDE Utils.


Description
-------

Filelight uses a divide-by-1024 trick to fit sizes over 4 GB into a
quint32. However, the current code will wrap around again at 4 TB.

Simply switch to quint64 and drop the use of divide-by-1024 trick to get
rid of the 4 TB wrap-around.

The performance penalty on a 32-bit system seems immeasurable. On a
filesystem with 1500000 files (13 TB) the process user time is only 1..5
seconds on i7-960, with quint32/64 having no effect. Most of the
wallclock time (20..500 sec in the above case, depending on cache
state) is spent waiting for I/O anyway.

Note that on 32-bit systems files over 2 GB are still completely ignored
unless built with large file support.


Note that this patch is on top of https://reviewboard.kde.org/r/102870/


Diffs
-----

  src/part/fileTree.h fe0a9ec 
  src/part/fileTree.cpp 6da7a8f 
  src/part/localLister.cpp 588a56a 
  src/part/remoteLister.cpp 139b7a7 
  src/part/summaryWidget.cpp ebbc516 

Diff: http://git.reviewboard.kde.org/r/103496/diff/diff


Testing
-------

Built git master with the patch, tested to fix wrap-around on both 64-bit and 32-bit systems, and checked briefly that performance didn't suffer as noted in the description.


Thanks,

Anssi Hannula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111221/6b2ca4ec/attachment.html>