Review Request: Fix bug 188857 "Ark follows settings in the Extraction dialog even when it was not used"

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6736/#review10355
-----------------------------------------------------------


Sorry for taking so long to answer.

The patch is on the right way, but showing an error message for that looks kind of annoying, even though we currently need to send an error message for things to work.

I suggest changing Job::onError() to make it accept an optional error number instead of the unused details parameter (it could default to UserDefinedError), so we can pass an error number which represents cancellation that would make the error dialog not be shown. It would look like this:

 * In kerfuffle/archive.h, create an enum like the one in kdelibs/kio/kio/global.h with error numbers.
 * Make onError accept an error code instead of the details parameter.
 * In the Part code, do not show the error message if the job was cancelled/aborted.



/trunk/KDE/kdeutils/ark/kerfuffle/jobs.cpp
<http://svn.reviewboard.kde.org/r/6736/#comment12106>

    This is not needed; the Q_UNUSED macro already expands to something which ends with a trailing ";"


- Raphael


On June 30, 2011, 12:33 a.m., Scott Leggett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6736/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 12:33 a.m.)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> Simple patch to display an error dialog and stop the ExtractJob when cancelling extraction of an archive in the 'overwrite query' dialog.
> 
> Fixes bug 188857 "Ark follows settings in the Extraction dialog even when it was not used"
> 
> 
> This addresses bug 188857.
>     https://bugs.kde.org/show_bug.cgi?id=188857
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp 1238821 
>   /trunk/KDE/kdeutils/ark/kerfuffle/jobs.cpp 1238821 
>   /trunk/KDE/kdeutils/ark/plugins/libarchive/libarchivehandler.cpp 1238821 
>   /trunk/KDE/kdeutils/ark/plugins/libsinglefileplugin/singlefileplugin.cpp 1238821 
> 
> Diff: http://svn.reviewboard.kde.org/r/6736/diff
> 
> 
> Testing
> -------
> 
> Extracted, then cancelled files which use the three different plugin types (in use): cli, libarchive, libsinglefile.
> 
> 
> Thanks,
> 
> Scott
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110810/91785249/attachment.html>