<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6736/">http://svn.reviewboard.kde.org/r/6736/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for taking so long to answer.
The patch is on the right way, but showing an error message for that looks kind of annoying, even though we currently need to send an error message for things to work.
I suggest changing Job::onError() to make it accept an optional error number instead of the unused details parameter (it could default to UserDefinedError), so we can pass an error number which represents cancellation that would make the error dialog not be shown. It would look like this:
* In kerfuffle/archive.h, create an enum like the one in kdelibs/kio/kio/global.h with error numbers.
* Make onError accept an error code instead of the details parameter.
* In the Part code, do not show the error message if the job was cancelled/aborted.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6736/diff/1/?file=46544#file46544line94" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeutils/ark/kerfuffle/jobs.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Job::start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">details</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">details</span><span class="p">)<span class="hl">;</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not needed; the Q_UNUSED macro already expands to something which ends with a trailing ";"</pre>
</div>
<br />
<p>- Raphael</p>
<br />
<p>On June 30th, 2011, 12:33 a.m., Scott Leggett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeutils.</div>
<div>By Scott Leggett.</div>
<p style="color: grey;"><i>Updated June 30, 2011, 12:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple patch to display an error dialog and stop the ExtractJob when cancelling extraction of an archive in the 'overwrite query' dialog.
Fixes bug 188857 "Ark follows settings in the Extraction dialog even when it was not used"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extracted, then cancelled files which use the three different plugin types (in use): cli, libarchive, libsinglefile.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=188857">188857</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp <span style="color: grey">(1238821)</span></li>
<li>/trunk/KDE/kdeutils/ark/kerfuffle/jobs.cpp <span style="color: grey">(1238821)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/libarchive/libarchivehandler.cpp <span style="color: grey">(1238821)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/libsinglefileplugin/singlefileplugin.cpp <span style="color: grey">(1238821)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>